Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

검색 결과 -> 기억 상세 라우팅 추가 #102

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

hogumachu
Copy link
Owner

🌁 연관 이슈

✅ 수정 내역

  • 검색 결과에서 기억 상세로 라우팅 추가
  • 기억 상세 제거 후 검색 결과 화면 refresh 하도록 추가
  • SearchReactor 테스트 작성

@hogumachu hogumachu added the 💻기능 기능 개발 label Jan 23, 2024
@hogumachu hogumachu self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (7305b76) 73.58% compared to head (5acf2c0) 75.47%.
Report is 5 commits behind head on develop.

Files Patch % Lines
...tation/Sources/SearchPresentation/SearchFlow.swift 0.00% 21 Missing ⚠️
...s/SearchPresentationTests/SearchReactorTests.swift 97.04% 5 Missing ⚠️
...rces/SearchPresentation/SearchViewController.swift 70.00% 3 Missing ⚠️
...ion/Sources/SearchPresentation/SearchReactor.swift 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
+ Coverage    73.58%   75.47%   +1.88%     
===========================================
  Files          156      186      +30     
  Lines         8189     9165     +976     
===========================================
+ Hits          6026     6917     +891     
- Misses        2163     2248      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogumachu hogumachu merged commit 1fa60ea into develop Jan 23, 2024
3 checks passed
@hogumachu hogumachu deleted the #56-feature/search-routing branch January 23, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻기능 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

검색 라우팅 추가
1 participant